chore(runtime): migrate to rslib bundleless#4352
chore(runtime): migrate to rslib bundleless#4352ScriptedAlchemy wants to merge 27 commits intomainfrom
Conversation
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 98317e719d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "import": { | ||
| "types": "./dist/index.d.ts", | ||
| "default": "./dist/index.esm.js" | ||
| "default": "./dist/index.js" | ||
| }, |
There was a problem hiding this comment.
Rslib’s ESM output defaults to .mjs in this repo (see the existing rslib-built package packages/modernjs which exports dist/esm/*.mjs), but the runtime package now points all ESM entrypoints to .js (e.g., ./dist/index.js). If rslib keeps emitting .mjs here as well, ESM consumers will hit MODULE_NOT_FOUND at runtime because the files referenced in module/exports.import don’t exist. Consider switching these ESM paths to .mjs (or explicitly configuring rslib to emit .js).
Useful? React with 👍 / 👎.
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Bundle Size Report8 package(s) changed, 30 unchanged.
Total dist: 6.39 MB (+14.3 kB (+0.2%)) |
# Conflicts: # .github/workflows/actionlint.yml
raven-actions/actionlint@v2 runs npm install internally which fails on pnpm workspace repos due to workspace:* protocol. Switch to direct binary download which has no npm dependency. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Resolve host/remote keys dynamically (supports typed keys like type:name). Co-authored-by: Cursor <cursoragent@cursor.com>
1 participant
Per-package rslib bundleless migration for runtime.